Skip to content

Account for BPM rounding in grouping setup

996c1e0
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Change song select grouping to be divided into 10 BPM groups #34381

Account for BPM rounding in grouping setup
996c1e0
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results failed Jul 28, 2025 in 0s

29071 passed, 1 failed and 256 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded.trx 7268✅ 64⚪ 1436s
TestResults-Linux-SingleThread.trx 7267✅ 1❌ 64⚪ 1135s
TestResults-Windows-MultiThreaded.trx 7268✅ 64⚪ 1818s
TestResults-Windows-SingleThread.trx 7268✅ 64⚪ 1580s

✅ TestResults-Linux-MultiThreaded.trx

7332 tests were completed in 1436s with 7268 passed, 0 failed and 64 skipped.

❌ TestResults-Linux-SingleThread.trx

7332 tests were completed in 1135s with 7267 passed, 1 failed and 64 skipped.

Test suite Passed Failed Skipped Time
osu.Game.Tests.Visual.Navigation.TestSceneSkinEditorNavigation 20✅ 1❌ 22s

❌ osu.Game.Tests.Visual.Navigation.TestSceneSkinEditorNavigation

✅ TestAutoplayCompatibleModsRetainedOnEnteringGameplay
✅ TestAutoplayIncompatibleModsRemovedOnEnteringGameplay
✅ TestChangeToNonSkinnableScreen
✅ TestCinemaModRemovedOnEnteringGameplay
✅ TestComponentsDeselectedOnSkinEditorHide
✅ TestConstructor
✅ TestDuplicateAutoplayModRemovedOnEnteringGameplay
✅ TestEditComponentFromGameplayScene
✅ TestGameplaySettingsDoesNotExpandWhenSkinOverlayPresent
✅ TestModOverlayClosesOnOpeningSkinEditor
✅ TestMutateProtectedSkinDuringGameplay
✅ TestMutateProtectedSkinFromMainMenu_UndoToInitialStateIsCorrect
❌ TestMutateProtectedSkinFromPlayer_UndoToInitialStateIsCorrect
	accuracy meter state unchanged: Expected string length 361 but was 356. Strings differ at index 138.
	  Expected: "...eyToken=null","Position":{"x":-20.0,"y":20.0},"Rotation":0..."
	  But was:  "...eyToken=null","Position":{"x":0.0,"y":0.0},"Rotation":0.0,..."
	  --------------------------------------------^
	
✅ TestOpenSkinEditorGameplaySceneOnBeatmapWithNoObjects
✅ TestOpenSkinEditorGameplaySceneWhenDifferentRulesetActive(1)
✅ TestOpenSkinEditorGameplaySceneWhenDifferentRulesetActive(2)
✅ TestOpenSkinEditorGameplaySceneWhenDifferentRulesetActive(3)
✅ TestOpenSkinEditorGameplaySceneWhenDummyBeatmapActive
✅ TestRulesetInputDisabledWhenSkinEditorOpen
✅ TestSkinSavesOnChange
✅ TestSwitchScreenWhileDraggingComponent

✅ TestResults-Windows-MultiThreaded.trx

7332 tests were completed in 1818s with 7268 passed, 0 failed and 64 skipped.

✅ TestResults-Windows-SingleThread.trx

7332 tests were completed in 1580s with 7268 passed, 0 failed and 64 skipped.

Annotations

Check failure on line 175 in osu.Game.Tests/Visual/Navigation/TestSceneSkinEditorNavigation.cs

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Game.Tests.Visual.Navigation.TestSceneSkinEditorNavigation ► TestMutateProtectedSkinFromPlayer_UndoToInitialStateIsCorrect

Failed test found in:
  TestResults-Linux-SingleThread.trx
Error:
  accuracy meter state unchanged: Expected string length 361 but was 356. Strings differ at index 138.
    Expected: "...eyToken=null","Position":{"x":-20.0,"y":20.0},"Rotation":0..."
    But was:  "...eyToken=null","Position":{"x":0.0,"y":0.0},"Rotation":0.0,..."
    --------------------------------------------^
  
Raw output
accuracy meter state unchanged: Expected string length 361 but was 356. Strings differ at index 138.
  Expected: "...eyToken=null","Position":{"x":-20.0,"y":20.0},"Rotation":0..."
  But was:  "...eyToken=null","Position":{"x":0.0,"y":0.0},"Rotation":0.0,..."
  --------------------------------------------^

   at osu.Game.Tests.Visual.Navigation.TestSceneSkinEditorNavigation.TestMutateProtectedSkinFromPlayer_UndoToInitialStateIsCorrect() in /home/runner/work/osu/osu/osu.Game.Tests/Visual/Navigation/TestSceneSkinEditorNavigation.cs:line 175