Add back "edit" context menu item on set panel headers #34380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
added
the
quick fix
Not sure how I feel about this. If it seems incorrect let's just not. As proposed in ppy#34119.
peppy
force-pushed
the
edit-from-set-panel
branch
from
15c9160 to
91f01ea
Compare
bdach
reviewed
Jul 28, 2025
| if (!Expanded.Value) | ||
| if (Expanded.Value) | ||
| { | ||
| if (songSelect is SoloSongSelect soloSongSelect) |
Collaborator
There was a problem hiding this comment.
The idea of this diff makes sense and I can't seem to break it on a quick check but I have very mixed feelings about this type of cast. We have ISongSelect which nicely abstracts this type of thing for all of the other panels and now here's this sort of stuff.
Thoughts on having a ISongSelect.GetForwardActions(BeatmapSetInfo) overload?
Member
Author
There was a problem hiding this comment.
We could do that. The only caveat is it couldn't be used in the other location I abstracted the beatmap version for (the footer menu) because that would mean the edit option would appear twice.
bdach
approved these changes
Jul 28, 2025
Collaborator
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
let's go with this as is for now then I guess
github-project-automation
bot
moved this from Pending Review
to Done
in osu! untitled project
This was referenced Aug 27, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how I feel about this. If it seems incorrect let's just not.
As proposed in #34119.