Fix playlists leaderboard provider not being thread safe #34316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #34222.
I haven't exactly managed to reproduce the issue myself but I'm relatively confident in the imagined mode of failure here. See
osu/osu.Game/Screens/OnlinePlay/Playlists/PlaylistsPlayer.cs
Lines 25 to 37 in 861a7e1
osu/osu.Game/Screens/OnlinePlay/Playlists/PlaylistsPlayer.cs
Line 53 in 861a7e1
Also comes with a side of (slightly) reduced number of collection change events fired.