Skip to content

Add ability to import all files from a directory to import files dialog #34303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bdach merged 6 commits into from
Jul 28, 2025
Merged

Add ability to import all files from a directory to import files dialog #34303

bdach merged 6 commits into from
Jul 28, 2025

Conversation

@Czer0xx
Copy link
Contributor

@Czer0xx Czer0xx commented Jul 20, 2025 •
edited by bdach
Loading

Screenshot 2025-07-28 at 13 05 03

bdach
bdach requested changes Jul 21, 2025
View reviewed changes
@bdach bdach added area:settings area:import dealing with importing of data from stable or file formats labels Jul 21, 2025
Czer0xx added 2 commits July 22, 2025 01:10
@Czer0xx
Applied changes from review
80539be 
 - Removed the try/catch block. (It was throwing an error only on Linux,
   when opened a symlink to directory to which user doesn't have access,
   idk if i should keep it or not.)
 - Replaced foreach loops with LINQ queries.
 - Replaced the copy-pasted startImport function with a call to it and
   changed its parameter type to "params string[]".
@Czer0xx
Removed unused directive, Replaced ".Where().Any()" with single call …
dad68d0 
…to Any().
@Czer0xx Czer0xx requested a review from bdach July 22, 2025 14:34
@bdach bdach changed the title Added 'Import all' button in 'Maintenance/Import files' Add ability to import all files from a directory to import files dialog Jul 28, 2025
@bdach bdach merged commit a5da221 into ppy:master Jul 28, 2025
9 checks passed
This was referenced Aug 27, 2025
Merged
Merged
Merged
Closed
This was referenced Sep 5, 2025
Closed
Closed
This was referenced Oct 3, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Oct 13, 2025
Closed
@dependabot dependabot bot mentioned this pull request Oct 29, 2025
Merged
@dependabot dependabot bot mentioned this pull request Dec 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdach bdach bdach approved these changes

Assignees

No one assigned

Labels

area:import dealing with importing of data from stable or file formats area:settings size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Czer0xx @bdach