Fix beatmap update button restarting animation at every hover #34283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have no clue how windows build failed on TestDeleteScoreAfterPlaying, I didn't even edit anything remotely related to scores or deleting... |
Contributor
Author
|
It's prompting me to get the current commits so I'm doing that. If its unneeded, I can stop. |
Contributor
I've noticed in other PRs that sometimes the tests just fail for existing. |
Joehuu
changed the title
Joehuu
approved these changes
Jul 20, 2025
Joehuu
added
area:song-select
type/cosmetic
peppy
approved these changes
Jul 20, 2025
This was referenced Aug 27, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the issue "Beatmap update button restarts animation at every hover" which was caused by the Spin method not being provided a startRotation (which defaulted it to 0F). This is a relatively small edit (2 lines plus its something visual), and in addition to that I don't really know how to test code, thats why there are no tests. (If you have time please tell me how)
This is my first proper pull request so please do tell me what I can do better later on!