Skip to content

Conversation

@EVAST9919
Copy link
Contributor

Closes #34243

2025-07-18.12-30-25.mp4

@peppy peppy self-requested a review July 18, 2025 09:52
@peppy
Copy link
Member

peppy commented Jul 18, 2025

Looking good.

Do you think we should also apply to the top timeline?

osu! 2025-07-18 at 09 53 06

There's no movement on these ones but they are quite sharp visually.

@bdach
Copy link
Collaborator

bdach commented Jul 18, 2025

I guess I'm not supposed to come into PRs like this anymore but this is the hackiest code I've seen in a hot minute. how does this even work? why is it reusing the shader for the bordered triangles for this? what is half the code in this PR doing? is someone going to realise that touching the bordered triangles shader potentially will break the appearance of editor now? why aren't framework triangle primitives getting AA instead? I have so many questions

@EVAST9919
Copy link
Contributor Author

EVAST9919 commented Jul 18, 2025

why aren't framework triangle primitives getting AA instead?

Framework triangles don't support antialiasing. But once you said that - I realised we can use boxes rotated by 45 degrees. Though we would still need a custom draw node to add ability to elongate them properly depending on the use case, but we can avoid shader usage

@peppy
Copy link
Member

peppy commented Jul 18, 2025

I get the code quality concerns but with something this local I'm personally willing to turn a blind eye to get-things-done (used in one place, private class, shader it's using is probably not going to change/break).

The box version does sound better if we can avoid some faff, but I don't want this to become a huge task, was just hoping for a quick 15 minute fix.

@EVAST9919
Copy link
Contributor Author

The box version does sound better if we can avoid some faff, but I don't want this to become a huge task, was just hoping for a quick 15 minute fix.

It's okay, not a huge task. I've made adjustments to avoid shader usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor bottom timeline's playhead slightly trembles

3 participants