Fix update manager throwing unhandled visible to users #34276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppy
added
area:installer
type/reliability
peppy
commented
Jul 18, 2025
peppy
commented
Jul 18, 2025
| } | ||
| catch (Exception e) | ||
| { | ||
| Logger.Log($"{nameof(PerformUpdateCheck)} failed ({e.Message})"); |
Member
Author
There was a problem hiding this comment.
This is a safety fallback in case any exceptions aren't caught inside of PerformUpdateCheck. It's not required to fix this issue per se, just a safety to keep me sane.
smoogipoo
requested changes
Jul 18, 2025
smoogipoo
approved these changes
Jul 18, 2025
This was referenced Aug 27, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackled this immediately as it is one cause of the unobserved errors which have been reported (#33760).
See
https://discord.com/channels/188630481301012481/1097318920991559880/1395623942437474405.