Fix android builds losing awareness of their release stream #34232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
approved these changes
Jul 15, 2025
This was referenced Aug 27, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably this tears out a lot of strange logic in
AssemblyVersionwhich as far as I can tell really is no longer relevant since fastlane was sent packing.It's a little bit weird maybe that
VersionreadsIsDeployedVersionwhich is based onAssemblyVersionwhich parses the same underlying version string but if I were to attempt to fix that I'd need to take a medium sized hammer to how versioning is done all over which I'd rather not, I think?I'm not particularly attached to this version, nor do I think that it's particularly any better than the other one (maybe other than the fact that it removes more code than it adds). Primarily offering this up as an alternative, I guess.