Change colour of BeatDivisorControl icons from black to light gray #33965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Just saw in #18393 (comment) that the flyte's design has a slight teal-ish tint here, can do this colour too but gonna hold off for now to see if there's any preference here |
Collaborator
|
this one is better imo |
Contributor
Author
|
Should match now. I also made the hover background colour a bit less bright so the icon has better contrast with the background |
peppy
approved these changes
Jul 1, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that the beat divisor controls are pretty much the only thing using black as icon colour in the editor always kinda bothered me so hoping we could switch it to a lighter colour to make it fit in more nicely