Fix Flashlight having increased radius when Barrel Roll is active #33910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was doing a "if I touch the game in this very specific manner everything works" which will light up in very nice green colours but is actually useless for preventing regressions.
smoogipoo
approved these changes
Jul 2, 2025
peppy
approved these changes
Jul 2, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Flashlight test case exercising playfield scaling not useless
It was doing a "if I touch the game in this very specific manner everything works" which will light up in very nice green colours but is actually useless for preventing regressions.
Fix Flashlight having increased radius when Barrel Roll is active
Closes #33893.
Regressed in #29841.
This sucks but I don't have better ideas.