Fix rotating objects in the skin editor not rotating as expected #33856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ppy#33845. Not sure if this ever worked but it was definitely wrong for a while now.
bdach
force-pushed
the
fix-skin-editor-rotation
branch
from
1f6c4ee to
4123d4a
Compare
bdach
approved these changes
Jun 24, 2025
Collaborator
bdach
left a comment
bdach
left a comment
There was a problem hiding this comment.
Force-pushed to fix a code quality inspection, but good otherwise
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33845.
Not sure if this ever worked but it was definitely wrong for a while now.
Notably, rotating multiple objects at once doesn't work too well, but I'm not going to fix that here (and not sure if it is expected to work; looks like it may require a much larger refactoring).