Visual pass on loading spinner #33723
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes regression mentioned [here](ppy#33509 (comment)). Adjust visuals and metrics slightly.
peppy
added
the
type/cosmetic
|
It seems the mask is not working properly in the notification, although it works correctly in the LoadingSpinner test Screen.Recording.2025-06-16.at.10.08.54.AM.mov
|
Member
Author
well spotted, i've fixed this. |
smoogipoo
approved these changes
Jun 16, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes regression mentioned here.
Adjust visuals and metrics slightly, sorry got carried away 🤷 .