Add localisation support to difficulty range slider #33698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frenzibyte
added
area:song-select
area:localisation
peppy
reviewed
Jun 15, 2025
| /// Lower bound display for when it is set to its default value, or null to display the value directly. | ||
| /// </summary> | ||
| public string DefaultStringLowerBound { get; init; } = string.Empty; | ||
| public LocalisableString? DefaultStringLowerBound { get; init; } |
Member
There was a problem hiding this comment.
This abstraction class is like, not sure we'll ever use it in another use cas 🤷
Member
|
Worth noting that tooltips feels absolutely bad and probably need to be fixed at a global level: 2025-06-15.23.46.38.mp4 |
peppy
approved these changes
Jun 15, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed some of the properties for tooltip / default string customization as they don't fit well with localisation or are unnecessary. I've replaced them with direct overrides in the slider pieces instead.