Fix results screen not showing local scores on results screen for some beatmap statuses #33610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e beatmap statuses Closes ppy#33609. Case of leftover code that should have been removed. This condition is still active in the online leaderboards path via https://github.com/ppy/osu/blob/4dcc928c7e46e020c62f4d60e7b859ba18c9142f/osu.Game/Online/Leaderboards/LeaderboardManager.cs#L91-L95 Not sure trying to add test coverage is a productive use of time? Will do on request though.
…han once This is a very dodgy fix, but it fixes an edge case that has so far - to my knowledge - not been reported by users in the wild, only by me trying to break things, so my hope is that we can do this and move on for now.
Collaborator
Author
|
c84988a is a bit dodgy change for a 'test fix' but I hope it can be understood after reading the commit message. #33612 is tangentially related to it, because the failure that the failing test produced is the same as the stack trace of the issue that PR is attempting to fix, but I see them as disparate issues. |
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33609.
Case of leftover code that should have been removed.
This condition is still active in the online leaderboards path via
osu/osu.Game/Online/Leaderboards/LeaderboardManager.cs
Lines 91 to 95 in 4dcc928
Not sure trying to add test coverage is a productive use of time? Will do on request though.