Fix simplified rhythm mod not working on some beatmaps #33502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@Hiviexd could you check if you agree with this, or if I've gravely missed the reason it was indexing to |
Member
|
I wrote the final logic and this looks to be an incorrect assumption. I think your change looks correct 👍. |
peppy
approved these changes
Jun 6, 2025
This was referenced Sep 5, 2025
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33467
Rather than adjusting every third object's position based on the next object (that may not exist), adjust it based on the second-last object. I'm not sure the original code was correct in the first place because we'd adjust based on the next pattern rather than the current pattern?
I don't know what to call the tests, so hopefully the xmldoc is good enough.