Add a consistency factor to osu!taiko diffcalc
#33233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buyaspacecube
approved these changes
May 22, 2025
Member
buyaspacecube
left a comment
buyaspacecube
left a comment
There was a problem hiding this comment.
code is nice and works as expected, looks good to me!
osu.Game.Rulesets.Taiko/Difficulty/TaikoDifficultyAttributes.cs
Outdated
Show resolved
Hide resolved
tsunyoku
moved this from Pending Merge
to Pending Review
in Difficulty calculation changes
tsunyoku
reviewed
May 22, 2025
tsunyoku
approved these changes
May 23, 2025
github-project-automation
bot
moved this from Pending Review
to Pending Deploy
in Difficulty calculation changes
Finadoggie
pushed a commit
to Finadoggie/osu
that referenced
this pull request
Aug 18, 2025
* add consistency attribute * write attributes to json for serialisation * comment change * fix json, add mechanical difficulty * write new attributes to database --------- Co-authored-by: James Wilson <[email protected]>
This was referenced Oct 29, 2025
stanriders
moved this from Pending Deploy
to Deployed
in Difficulty calculation changes
This was referenced Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comments are self explanatory, will be used within the skill split happening soon in order to better scale reading values from maps that are consistently difficult, or inconsistent. As peaks is precalculated and this only grabs a descending list, its very minimal on performance.
Currently purely an attribute, and will need to be written to db when its respective feature pr comes out.