-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Fix incorrect limit for sliderbreak estimation #33110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
!diffcalc |
This comment was marked as outdated.
This comment was marked as outdated.
|
!diffcalc |
This comment was marked as outdated.
This comment was marked as outdated.
|
!diffcalc |
This comment was marked as outdated.
This comment was marked as outdated.
|
!diffcalc |
* fix incorrect clamp * Add inline comment to explain `possibleBreaks` calculation * move limit to aim and speed functions * fix negative okMehAdjustment * fix cases where lazer effective misscount gets reduced * Simplify scope of changes * Correct variable name --------- Co-authored-by: James Wilson <[email protected]>
This score https://osu.ppy.sh/scores/4357222093 being estimated to have more than 1 sliderbreak despite being only 1x100 it estimates effectiveMisscount to be 1 using Math.Min, and then adds additional sliderbreaks with also using Math.Min
so it can estimate up to 2 sliderbreaks in case of 1x100