Skip to content

Conversation

@Givikap120
Copy link
Contributor

This score https://osu.ppy.sh/scores/4357222093 being estimated to have more than 1 sliderbreak despite being only 1x100 it estimates effectiveMisscount to be 1 using Math.Min, and then adds additional sliderbreaks with also using Math.Min
so it can estimate up to 2 sliderbreaks in case of 1x100

@ppy ppy deleted a comment from github-actions bot May 13, 2025
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

@tsunyoku tsunyoku merged commit 366f246 into ppy:pp-dev Jun 3, 2025
4 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Pending Review to Pending Deploy in Difficulty calculation changes Jun 3, 2025
Finadoggie pushed a commit to Finadoggie/osu that referenced this pull request Aug 18, 2025
* fix incorrect clamp

* Add inline comment to explain `possibleBreaks` calculation

* move limit to aim and speed functions

* fix negative okMehAdjustment

* fix cases where lazer effective misscount gets reduced

* Simplify scope of changes

* Correct variable name

---------

Co-authored-by: James Wilson <[email protected]>
@stanriders stanriders moved this from Pending Deploy to Deployed in Difficulty calculation changes Oct 29, 2025
@Givikap120 Givikap120 deleted the fix-sb-incorrect-clamp branch October 30, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Deployed

Development

Successfully merging this pull request may close these issues.

3 participants