Skip to content

Fix skin editor anchor/origin context menu ternary states not updating properly #32641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
peppy merged 3 commits into from
Mar 31, 2025
Merged

Fix skin editor anchor/origin context menu ternary states not updating properly #32641

peppy merged 3 commits into from
Mar 31, 2025

Conversation

@bdach
Copy link
Collaborator

@bdach bdach commented Mar 31, 2025

bdach and others added 2 commits March 31, 2025 14:25
@bdach bdach self-assigned this Mar 31, 2025
@bdach bdach mentioned this pull request Mar 31, 2025
Closed
bdach
bdach commented Mar 31, 2025
View reviewed changes
osu.Game/Overlays/SkinEditor/SkinSelectionHandler.cs
Comment on lines -121 to -124
// For UX simplicity, origin should only be user-editable when "closest" anchor mode is disabled.
originMenu.Items = s.NewValue == TernaryState.True
? Array.Empty<MenuItem>()
: createAnchorItems((d, o) => ((Drawable)d).Origin == o, applyOrigins).ToArray();
Copy link
Collaborator Author

@bdach bdach Mar 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is replaced by disabling all 9 items instead. This is because this code is janky at best on master right now (if you right-click closest anchor, the origin menu won't disable until you move away from the anchor submenu somewhere else), and it can't be brought back in the new updateTernaryStates() method because menu items just don't work like that. It's a bit of a magic API.

@peppy peppy self-requested a review March 31, 2025 14:40
@peppy peppy merged commit 596b703 into ppy:master Mar 31, 2025
10 checks passed
@bdach bdach deleted the skin-menu-checkboxes branch April 1, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peppy peppy peppy approved these changes

Assignees

@bdach bdach

Labels

area:skin-editor size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Skin anchor menu checkmarks don't update when right-clicking

2 participants

@bdach @peppy