Skip to content

Conversation

@LukynkaCZE
Copy link
Contributor

This PR adds Argon style judgement counter skin component

I was originally gonna add ability to change the font on the existing one because honestly the old font really doesn't look great on it but I realized there is no numeric font variant for Torus and it looked really off with the number width changing all the time so I decided to make new argon styled one instead

The label colors are based on the hit result colors (same as existing one). The actual counter text is white by default but when "Show Label" is turned off, it changes to hit result colors so its obvious which number is what

argon.judgement.counter.mp4

@Joehuu Joehuu added type/cosmetic Only affects the game visually. Doesn't affect things working or not working. area:skinning labels Mar 8, 2025
@ItsShamed
Copy link
Contributor

I would have hoped for it to look like the Argon Key Counter (like in the Figma designs)

image

@LukynkaCZE
Copy link
Contributor Author

I would have hoped for it to look like the Argon Key Counter (like in the Figma designs)

image

I think it would be too confusing to have 2 components with the same design as key counter. PF, GD, PS, X also don't make too much sense in my opinion, especially when not colour coded. But that is just my opinion obv, open to suggestions. I reused the argon counters since they're used for other metrics already and I think they look great

@felipemarins
Copy link
Contributor

As I suggested on #30407, if you're going to use the figma design, I think you can add colours to the lines above the judgements. As for the judgement names on the figma, I agree that changing that would be preferable.

@peppy peppy self-requested a review March 10, 2025 08:41
@BunnyTub
Copy link

BunnyTub commented Apr 8, 2025

I don't know if I'm the only one, but the color on the argon wire frame pops really well with the design language of it.

@copecone
Copy link

copecone commented Sep 1, 2025

It would be beneficial to add a default number of decimal places to the indicator.

@peppy peppy removed their request for review September 3, 2025 06:15
@peppy peppy moved this from Next up to Pending Review in osu! untitled project Sep 3, 2025
@bdach bdach self-assigned this Sep 3, 2025
@bdach bdach self-requested a review September 3, 2025 10:59
@bdach
Copy link
Collaborator

bdach commented Sep 3, 2025

Aside from a56f81a, I thought that this looked terrible:

Screenshot 2025-09-03 at 13 43 05

so I pushed 98c3437 to turn that into this:

Screenshot 2025-09-03 at 13 41 09

@peppy requesting a visual pass on this

@peppy peppy self-requested a review September 3, 2025 12:30
@peppy peppy merged commit 23d10cc into ppy:master Sep 3, 2025
5 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Pending Review to Done in osu! untitled project Sep 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:skinning size/L type/cosmetic Only affects the game visually. Doesn't affect things working or not working.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants