Skip to content

Conversation

@cdwcgt
Copy link
Contributor

@cdwcgt cdwcgt commented Dec 10, 2023

Most of the code draws on BarHitErrorMeter and AccuracyHeatmap

The design is basically derived from mcosu’s position indicator

osu.development.2024-01-26.14-11-43_x264.mp4

Alpha = 0;

this
.FadeTo(1f, judgement_fade_in_duration, Easing.OutQuint)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FadeInFromZero is safer here, else you might somehow get a drawable returned to the pool which wasn't at zero alpha causing a sudden transition.

Copy link
Contributor Author

@cdwcgt cdwcgt Dec 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am already apply it

used in danser and I think this is better
@cdwcgt cdwcgt changed the title Add HitPosistionMeter Add AimErrorMeter Dec 10, 2023
@cdwcgt
Copy link
Contributor Author

cdwcgt commented Dec 10, 2023

image
I'm a little undecided. Do we need to add a point in the center as a reference?

@RushFTK
Copy link

RushFTK commented Dec 10, 2023

I think it's optional and need to do visiual adjust, letting user now it's a not important element. (ref), adding alpha for point itself is fine.

@Tanza3D
Copy link

Tanza3D commented Dec 10, 2023

image I'm a little undecided. Do we need to add a point in the center as a reference?

perhaps a cross?
image

@peppy
Copy link
Member

peppy commented Dec 11, 2023

I would have preferred if this matches the design/display as the results screen. It's unclear as to the direction of this. Which is to say it's probably not based on direction and therefore doesn't match the results screen at all, creating confusion and potentially being less useful.

@cdwcgt
Copy link
Contributor Author

cdwcgt commented Dec 11, 2023

Maybe we can separate them into two modes.

let it like accuracy heatmap is not too difficult, but in this case, the player can know where the previous object is and most of it is used for playback(emm danser?) to check where its clicked.
So I want keep both these display mode.

/// <summary>
/// "Judgement position size"
/// </summary>
public static LocalisableString JudgementSize => new TranslatableString(getKey(@"judgement_line_thickness"), "Judgement position size");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should've been auto-generated. Keys are copy-pasted and never changed and keys/string should be verbatim.

@peppy peppy merged commit aba160f into ppy:master Aug 19, 2025
6 of 9 checks passed
@github-project-automation github-project-automation bot moved this from Next up to Done in osu! untitled project Aug 19, 2025
@bdach bdach changed the title Add AimErrorMeter Add aim error meter skin component Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

8 participants