-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add aim error meter skin component #25716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Alpha = 0; | ||
|
|
||
| this | ||
| .FadeTo(1f, judgement_fade_in_duration, Easing.OutQuint) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FadeInFromZero is safer here, else you might somehow get a drawable returned to the pool which wasn't at zero alpha causing a sudden transition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am already apply it
used in danser and I think this is better
|
I think it's optional and need to do visiual adjust, letting user now it's a not important element. (ref), adding alpha for point itself is fine. |
|
I would have preferred if this matches the design/display as the results screen. It's unclear as to the direction of this. Which is to say it's probably not based on direction and therefore doesn't match the results screen at all, creating confusion and potentially being less useful. |
|
Maybe we can separate them into two modes. let it like accuracy heatmap is not too difficult, but in this case, the player can know where the previous object is and most of it is used for playback(emm danser?) to check where its clicked. |
| /// <summary> | ||
| /// "Judgement position size" | ||
| /// </summary> | ||
| public static LocalisableString JudgementSize => new TranslatableString(getKey(@"judgement_line_thickness"), "Judgement position size"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should've been auto-generated. Keys are copy-pasted and never changed and keys/string should be verbatim.



Most of the code draws on
BarHitErrorMeterandAccuracyHeatmapThe design is basically derived from mcosu’s position indicator
osu.development.2024-01-26.14-11-43_x264.mp4