Skip to content

Conversation

@002love
Copy link

@002love 002love commented Dec 27, 2025

Resolves #12533

This PR implements logic to hide the "bad standing" warning for minor infractions, as discussed in the issue

Key changes:

  • warning is hidden for regular users if recent silences are <24h and inactive
  • moderators still see the warning if any history exists (preserving visibility for staff)
  • threshold of 3+ infringements triggers the warning regardless of length

Includes PHPUnit tests covering all logic branches

Copy link
Contributor

@LiquidPL LiquidPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is already pretty good, there's just one thing to change

@002love
Copy link
Author

002love commented Dec 28, 2025

Thanks for the feedback, applied all requested changes:

  • renamed hasBadStanding to inBadStanding in the model and moved the moderator logic to the UserTransformer
  • refactored isAfter() to isFuture()
  • cleaned up config_set calls in unit tests

Copy link
Contributor

@LiquidPL LiquidPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the "Account not in good standing" text appear only when recent infringements are bad enough

3 participants