Wrapped UI #12624
Open
Wrapped UI #12624
+2,312
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notbakaneko
commented
Dec 27, 2025
| $user = User::findOrFail($userId); | ||
|
|
||
| // TODO: stuff actually needs to go in here from https://github.com/ppy/osu-web/pull/12614 | ||
| $json = [ |
Collaborator
Author
There was a problem hiding this comment.
actual json needs to go here
Comment on lines
8
to
10
| import sampleData from 'wrapped-show/sums/summary-8447637.json'; | ||
|
|
||
| const userId = 8447637; |
Collaborator
Author
There was a problem hiding this comment.
directly imported data for testing that isn't included in the PR
are you serious
notbakaneko
force-pushed
the
wrapped-2025
branch
from
eefde2d to
6df20e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to redo (more like make up) a lot of stuff upon discovering the page flow of original design didn't quite work once proper data starts getting displayed and the window isn't a fixed width or height, and apparently there isn't a css way to "fit as many columns as possible in a grid but have the columns variable size and still line up and not have contents inside wrap/overflow"
Most of it are in the same files so it's easier to remove.
There are a lot of css variables to make it easier to me to adjust the sizes ಠ_ಠ