Skip to content

Conversation

@someonecantcode
Copy link
Contributor

@someonecantcode someonecantcode commented Dec 9, 2025

supersedes #12431
resolves #12356

in #12431, kama talks about rewriting the <center> implementation since it is deprecated but i don't know if i should do something about it. Quick question, if this gets merged, should i update the documentation in https://github.com/ppy/osu-wiki/blob/master/wiki/BBCode/en.md ?

Tested for main audio, spoilerboxes, videos results:
image

@peppy
Copy link
Member

peppy commented Dec 11, 2025

Also seen in #12431.

Copy link
Contributor

@LiquidPL LiquidPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

the box/spoilerbox header can get left aligned when open

Comment on lines 108 to 110
.js-spoilerbox {
display: inline-block;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should probably reference .bbcode-spoilerbox instead.

@someonecantcode
Copy link
Contributor Author

someonecantcode commented Dec 29, 2025

image the box/spoilerbox header can get left aligned when open

hello im not sure what you meant by "header can get left aligned when open"? I wasn't able to recreate what you said.

[right][box=NAME]
text
[/box][/right]

[right][spoilerbox]text[/spoilerbox][/right]



[spoilerbox]text[/spoilerbox]

[spoilerbox][right]text[/right][/spoilerbox]
image

Anyways, yeah thanks for the catch on the .js-spoilerbox; I changed it to .bbcode-spoilerbox instead and works the same. I will rebase and squash in a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add [right] alignment tag to forum BBCode

3 participants