-
Notifications
You must be signed in to change notification settings - Fork 108
Sync default legacy skin resources with implementation #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
What's the idea here? Remove things we're not using only to add them back when we end up using them? |
|
As long as I understand your idea, with deleting sprites, I don't like it. The fact we don't have a countdown yet, doesn't mean we should get rid of it's sprites (I remember I saw a PR, which was implementing countdown on legacy skins already). Same goes to comboburst, since lack of it's current logic doesn't imply it's full removal, in my eyes. Removing samples is related to what I said about sprites. |
for some of the removals, yes -- the main point of this is finding where to draw the line so that I can decide which files to add for my initial PR of the "2007" default skin, which I want to stay roughly in sync with the 2013 skin. there are a lot of odd cases with these unused files that made me think they were all just accidentally included. I get what you're saying though, I restored files that seem like they may be used soon:
and what I mean by some of these "odd cases" in
nor does this PR, I'm only trying to clean up what's here right now |
I mistakenly thought these were unused
|
I think I'd prefer not removing any assets, because other than removing |
this PR makes the legacy default skin include all resources from stable that are used in lazer, and removes any extras. the only exceptions are
seeyaandwelcomesamples, which are coupled withIntroScreenlogic in a way that wouldn't make sense for this default skin to be overridingthis makes my work on ppy/osu#20659 a bit easier because I don't have to think about where to draw the line for which textures to include, and also I can have sample lookups fall back from 2007 to 2013 without worry that any 2013 ones will change later on (for example,
pause-loopis currently a duplicate ofSamples/Gameplay/pause-loop, but that may not be the case forever).