Gradually replace API query for score rank with dedicated cache #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly resolves ppy#346. Using a gradual rollout strategy where `RANK_LOOKUP_CACHE_TRAFFIC_RATIO` of requests (defaults to 5%) are routed to the relevant rank lookup cache instance post-ppy/osu-global-rank-lookup-cache#3, and the rest is still serviced by web. The goal is to see how hard the lookup cache falls over as load increases and potentially tweak its behaviour in response.
bdach
commented
Nov 21, 2025
| { | ||
| SentrySdk.CaptureMessage($"Failed to retrieve score rank from lookup cache: received status code {response.StatusCode}, content: {responseContent}", | ||
| SentryLevel.Warning); | ||
| DogStatsd.Increment("osu.user_rank_cached_lookup", 1, tags: ["type:scores", "result:fail"]); |
Collaborator
Author
There was a problem hiding this comment.
Note that this is an existing counter and therefore if this is OK that one will need some slight adjusting to tags.
Collaborator
Author
|
Blocking for now because the rank lookup service is already so slow on new tables that I wouldn't put a sliver of load on it. Will regroup there and figure out how to leverage ES better so it's not so dog slow. Edit: See ppy/osu-global-rank-lookup-cache#4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scorestable pathways osu-global-rank-lookup-cache#4Mostly resolves #346.
Using a gradual rollout strategy where
RANK_LOOKUP_CACHE_TRAFFIC_RATIOof requests (defaults to 5%) are routed to the relevant rank lookup cache instance post-ppy/osu-global-rank-lookup-cache#3, and the rest is still serviced by web.The goal is to see how hard the lookup cache falls over as load increases and potentially tweak its behaviour in response.