Skip to content

Expose experimental WASAPI support as a user config toggle #6659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smoogipoo merged 1 commit into from
Oct 25, 2025
Merged

Expose experimental WASAPI support as a user config toggle #6659

smoogipoo merged 1 commit into from
Oct 25, 2025
+28 −15

Conversation

@peppy
Copy link
Member

@peppy peppy commented Oct 25, 2025

No description provided.

@peppy peppy mentioned this pull request Oct 25, 2025
Merged
2 tasks
smoogipoo
smoogipoo approved these changes Oct 25, 2025
View reviewed changes
Copy link
Contributor

@smoogipoo smoogipoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay to me but I haven't tested yet.

@smoogipoo
Copy link
Contributor

smoogipoo commented Oct 25, 2025 •
edited
Loading

Should I be concerned we're initialising the bass device 4 times?

[runtime] 2025-10-25 07:59:40 [verbose]: Initialising BassWasapi for device -1...success!
[runtime] 2025-10-25 07:59:40 [verbose]: 🔈 BASS initialised
[runtime] 2025-10-25 07:59:40 [verbose]: BASS version:           2.4.17.48
[runtime] 2025-10-25 07:59:40 [verbose]: BASS FX version:        2.4.12.16
[runtime] 2025-10-25 07:59:40 [verbose]: BASS MIX version:       2.4.12.10
[runtime] 2025-10-25 07:59:40 [verbose]: Device:                 Default
[runtime] 2025-10-25 07:59:40 [verbose]: Driver:
[runtime] 2025-10-25 07:59:40 [verbose]: Update period:          5 ms
[runtime] 2025-10-25 07:59:40 [verbose]: Device buffer length:   10 ms
[runtime] 2025-10-25 07:59:40 [verbose]: Playback buffer length: 100 ms
[runtime] 2025-10-25 07:59:40 [verbose]: 🔈 BASS initialised
[runtime] 2025-10-25 07:59:40 [verbose]: BASS version:           2.4.17.48
[runtime] 2025-10-25 07:59:40 [verbose]: BASS FX version:        2.4.12.16
[runtime] 2025-10-25 07:59:40 [verbose]: BASS MIX version:       2.4.12.10
[runtime] 2025-10-25 07:59:40 [verbose]: Device:                 Default
[runtime] 2025-10-25 07:59:40 [verbose]: Driver:
[runtime] 2025-10-25 07:59:40 [verbose]: Update period:          5 ms
[runtime] 2025-10-25 07:59:40 [verbose]: Device buffer length:   10 ms
[runtime] 2025-10-25 07:59:40 [verbose]: Playback buffer length: 100 ms
[runtime] 2025-10-25 07:59:40 [verbose]: 🔈 BASS initialised
[runtime] 2025-10-25 07:59:40 [verbose]: BASS version:           2.4.17.48
[runtime] 2025-10-25 07:59:40 [verbose]: BASS FX version:        2.4.12.16
[runtime] 2025-10-25 07:59:40 [verbose]: BASS MIX version:       2.4.12.10
[runtime] 2025-10-25 07:59:40 [verbose]: Device:                 Default
[runtime] 2025-10-25 07:59:40 [verbose]: Driver:
[runtime] 2025-10-25 07:59:40 [verbose]: Update period:          5 ms
[runtime] 2025-10-25 07:59:40 [verbose]: Device buffer length:   10 ms
[runtime] 2025-10-25 07:59:40 [verbose]: Playback buffer length: 100 ms
[runtime] 2025-10-25 07:59:40 [verbose]: 🔈 BASS initialised
[runtime] 2025-10-25 07:59:40 [verbose]: BASS version:           2.4.17.48
[runtime] 2025-10-25 07:59:40 [verbose]: BASS FX version:        2.4.12.16
[runtime] 2025-10-25 07:59:40 [verbose]: BASS MIX version:       2.4.12.10
[runtime] 2025-10-25 07:59:40 [verbose]: Device:                 Default
[runtime] 2025-10-25 07:59:40 [verbose]: Driver:
[runtime] 2025-10-25 07:59:40 [verbose]: Update period:          5 ms
[runtime] 2025-10-25 07:59:40 [verbose]: Device buffer length:   10 ms
[runtime] 2025-10-25 07:59:40 [verbose]: Playback buffer length: 100 ms

My concern here is one of these 4 initialises potentially going in without the wasapi experimental flag.

@smoogipoo smoogipoo merged commit a6692e6 into ppy:master Oct 25, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Next up to Done in osu! untitled project Oct 25, 2025
@peppy
Copy link
Member Author

peppy commented Oct 25, 2025

Should I be concerned we're initialising the bass device 4 times?


[runtime] 2025-10-25 07:59:40 [verbose]: Initialising BassWasapi for device -1...success!

[runtime] 2025-10-25 07:59:40 [verbose]: 🔈 BASS initialised

[runtime] 2025-10-25 07:59:40 [verbose]: BASS version:           2.4.17.48

[runtime] 2025-10-25 07:59:40 [verbose]: BASS FX version:        2.4.12.16

[runtime] 2025-10-25 07:59:40 [verbose]: BASS MIX version:       2.4.12.10

[runtime] 2025-10-25 07:59:40 [verbose]: Device:                 Default

[runtime] 2025-10-25 07:59:40 [verbose]: Driver:

[runtime] 2025-10-25 07:59:40 [verbose]: Update period:          5 ms

[runtime] 2025-10-25 07:59:40 [verbose]: Device buffer length:   10 ms

[runtime] 2025-10-25 07:59:40 [verbose]: Playback buffer length: 100 ms

[runtime] 2025-10-25 07:59:40 [verbose]: 🔈 BASS initialised

[runtime] 2025-10-25 07:59:40 [verbose]: BASS version:           2.4.17.48

[runtime] 2025-10-25 07:59:40 [verbose]: BASS FX version:        2.4.12.16

[runtime] 2025-10-25 07:59:40 [verbose]: BASS MIX version:       2.4.12.10

[runtime] 2025-10-25 07:59:40 [verbose]: Device:                 Default

[runtime] 2025-10-25 07:59:40 [verbose]: Driver:

[runtime] 2025-10-25 07:59:40 [verbose]: Update period:          5 ms

[runtime] 2025-10-25 07:59:40 [verbose]: Device buffer length:   10 ms

[runtime] 2025-10-25 07:59:40 [verbose]: Playback buffer length: 100 ms

[runtime] 2025-10-25 07:59:40 [verbose]: 🔈 BASS initialised

[runtime] 2025-10-25 07:59:40 [verbose]: BASS version:           2.4.17.48

[runtime] 2025-10-25 07:59:40 [verbose]: BASS FX version:        2.4.12.16

[runtime] 2025-10-25 07:59:40 [verbose]: BASS MIX version:       2.4.12.10

[runtime] 2025-10-25 07:59:40 [verbose]: Device:                 Default

[runtime] 2025-10-25 07:59:40 [verbose]: Driver:

[runtime] 2025-10-25 07:59:40 [verbose]: Update period:          5 ms

[runtime] 2025-10-25 07:59:40 [verbose]: Device buffer length:   10 ms

[runtime] 2025-10-25 07:59:40 [verbose]: Playback buffer length: 100 ms

[runtime] 2025-10-25 07:59:40 [verbose]: 🔈 BASS initialised

[runtime] 2025-10-25 07:59:40 [verbose]: BASS version:           2.4.17.48

[runtime] 2025-10-25 07:59:40 [verbose]: BASS FX version:        2.4.12.16

[runtime] 2025-10-25 07:59:40 [verbose]: BASS MIX version:       2.4.12.10

[runtime] 2025-10-25 07:59:40 [verbose]: Device:                 Default

[runtime] 2025-10-25 07:59:40 [verbose]: Driver:

[runtime] 2025-10-25 07:59:40 [verbose]: Update period:          5 ms

[runtime] 2025-10-25 07:59:40 [verbose]: Device buffer length:   10 ms

[runtime] 2025-10-25 07:59:40 [verbose]: Playback buffer length: 100 ms

My concern here is one of these 4 initialises potentially going in without the wasapi experimental flag.

I've brought this up before. Not sure it's any worse with this PR. I think it's worth investigating since IIRC initialising bass is slightly time consuming.

@failaip12
Copy link

failaip12 commented Oct 25, 2025

I did some additional investigation into the initialization issue, and it appears to be somewhat misleading. The InitBass function performs a preliminary check before doing any actual initialization work, so the logs can give the impression that initialization occurred even when it didn’t.

osu-framework/osu.Framework/Audio/AudioManager.cs

Lines 409 to 410 in a6692e6

if (Bass.CurrentDevice == device)
return true;

This highlights two related issues:

  1. Changing the “Use experimental audio mode” setting has no effect once InitBass has already been loaded.

  2. There’s a potential (i didn't manage to produce it) scenario where InitBass could initialize without the WASAPI experimental flag, even when that flag is enabled.

@smoogipoo smoogipoo mentioned this pull request Oct 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoogipoo smoogipoo smoogipoo approved these changes

Assignees

No one assigned

Labels

area:audio size/M

Projects

osu! untitled project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@peppy @smoogipoo @failaip12