Add basic log output when using BassWasapi initialisation #6656
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoogipoo
reviewed
Oct 22, 2025
|
|
||
| Logger.Log($"Initialising BassWasapi for device {wasapiDevice}..."); | ||
| bool initialised = BassWasapi.Init(wasapiDevice, Procedure: wasapiProcedure, Flags: WasapiInitFlags.EventDriven | WasapiInitFlags.AutoFormat, Buffer: 0f, Period: float.Epsilon); | ||
| Logger.Log(initialised ? "..success" : "..failed"); |
Contributor
There was a problem hiding this comment.
Imo you should put the full message in here, I don't know how noisy this log is at startup.
Previous impossible to know if it was used or not.
peppy
force-pushed
the
wasapi-log-output
branch
from
2a6348f to
460ce14
Compare
smoogipoo
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous impossible to know if it was used or not.