Skip to content

Reduce memory usage of slot health check #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/young-rockets-behave.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@powersync/service-core': patch
---

Fix "JavaScript heap out of memory" on startup (slot health check)
15 changes: 11 additions & 4 deletions packages/service-core/src/replication/WalStream.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,15 +209,22 @@ export class WalStream {
// We peek a large number of changes here, to make it more likely to pick up replication slot errors.
// For example, "publication does not exist" only occurs here if the peek actually includes changes related
// to the slot.
await this.connections.pool.query({
statement: `SELECT *
FROM pg_catalog.pg_logical_slot_peek_binary_changes($1, NULL, 1000, 'proto_version', '1',
'publication_names', $2)`,
logger.info(`Checking ${slotName}`);

// The actual results can be quite large, so we don't actually return everything
// due to memory and processing overhead that would create.
const cursor = await this.connections.pool.stream({
statement: `SELECT 1 FROM pg_catalog.pg_logical_slot_peek_binary_changes($1, NULL, 1000, 'proto_version', '1', 'publication_names', $2)`,
params: [
{ type: 'varchar', value: slotName },
{ type: 'varchar', value: this.publication_name }
]
});

for await (let _chunk of cursor) {
// No-op, just exhaust the cursor
}

// Success
logger.info(`Slot ${slotName} appears healthy`);
return { needsInitialSync: false };
Expand Down
Loading