Fix crash when a special var points to another special var #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
When a var has a special varno (ie a negative varno), we need to resolve the actual underlying Var, as we would otherwise end up reading random memory when trying to access the associated RangeTblEntry. The previous code was correctly resolving such Var, but didn't consider the possibility that the resolved Var could itself have a special varno which needs to be resolved again. Thanks to Kenny Chen for the report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a var has a special varno (ie a negative varno), we need to resolve the actual underlying Var, as we would otherwise end up reading random memory when trying to access the associated RangeTblEntry. The previous code was correctly resolving such Var, but didn't consider the possibility that the resolved Var could itself have a special varno which needs to be resolved again.
Thanks to Kenny Chen for the report.