-
Notifications
You must be signed in to change notification settings - Fork 227
Async PG support #412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Async PG support #412
Conversation
@@ -1141,9 +1166,14 @@ where | |||
|
|||
// Sync | |||
// Frontend (client) is asking for the query result now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to update these docs to include Flush. Something like:
// Sync (S)
// Frontend (client) is asking for the query result now.
// ... or ...
// Flush (H)
// Frontend (client) is asking for server to send query results now without
// sync.
This looks pretty good to me. Conflicts should be pretty easy to resolve. Is there something about this that you don't love that keeps this in a draft state? |
I don't think it actually works. I tested it locally, but it fails in CI. Haven't had time to investigate further yet. |
Hi, any update with this issue, I have similar problem when running this with python code. Thanks for update |
Would love a progress update on this one |
) | ||
.await | ||
{ | ||
let message = tokio::select! { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this idea trying to see if this helps with #303
Something else it's missing that doesn't allow to send the server messages to the client. Maybe this 2 issues are related and could be solved both with the same fix
Fix #396