assistant: ensure variables are included in context and tool calls #8643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the access keys are not specified, are empty, or only contain empty arrays, do the all vars list
|
E2E Tests 🚀 |
sharon-wang
changed the title
sharon-wang
commented
Jul 23, 2025
| @@ -329,7 +329,7 @@ | |||
| { | |||
| "name": "inspectVariables", | |||
| "displayName": "Inspect Variables", | |||
| "modelDescription": "List the children of an array of variables in a session. For example, the columns in a dataframe, items in a column or array, or elements of a list. If `accessKeys` is empty, lists all root-level variables in the session.\n\nIf the user references a variable by name, first determine the `access_key` from the user context or a previous inspect variables result.\n\nDo not call when:\n - the variables do not appear in the user context\n - there is no session (the session identifier is empty or not defined)", | |||
| "modelDescription": "List the children of an array of variables in a session. For example, the columns in a dataframe, items in a column or array, or elements of a list. If `accessKeys` is empty, lists all root-level variables in the session.\n\nIf the user references a variable by name, first determine the `access_key` from the user context or a previous inspect variables result.", | |||
There was a problem hiding this comment.
- removed
Do not call when: the variables do not appear in the user contextsince this didn't seem to be respected by the models anyways - removed
Do not call when: there is no session (the session identifier is empty or not defined)since it is covered in Assistant: Don't provide tools to models in invalid contexts #8078
Comment on lines
+391
to
+398
| let sessionContent = sessionSummary; | ||
| if (value.variables) { | ||
| // Include the session variables in the session content. | ||
| const variablesSummary = JSON.stringify(value.variables, null, 2); | ||
| sessionContent += '\n' + xml.node('variables', variablesSummary); | ||
| } | ||
| sessionPrompts.push(xml.node('session', sessionContent)); | ||
| log.debug(`[context] adding session context for session ${value.activeSession.identifier}: ${sessionContent.length} characters`); |
There was a problem hiding this comment.
ensure we are pushing variables info into the session context
Comment on lines
+1592
to
+1593
| const accessKeysProvided = !!accessKeys && accessKeys.length > 0 && accessKeys.some(key => key.length !== 0); | ||
| if (accessKeysProvided) { |
There was a problem hiding this comment.
ensure there is at least one access key for inspection, otherwise list all variables
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Release Notes
Bug Fixes
QA Notes
@:assistant
See #8641 and #8642 -- thanks for the repro steps!