Skip to content

Respect include argument when querying for content with GUID #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 13, 2025

Conversation

karawoo
Copy link
Contributor

@karawoo karawoo commented May 9, 2025

Intent

Connect$content() has an argument include where additional query parameters can be specified, but when guid was provided we were not respecting the include arg.

Fixes #411

Approach

Included the include value when querying by GUID.

Checklist

  • Does this change update NEWS.md (referencing the connected issue if necessary)?
  • Does this change need documentation? Have you run devtools::document()?

@karawoo karawoo requested a review from a team May 9, 2025 22:14
@karawoo karawoo marked this pull request as draft May 9, 2025 22:19
@karawoo
Copy link
Contributor Author

karawoo commented May 9, 2025

ok, this has more downstream impacts than I realized so marking as a draft for now while I sort it out.

@karawoo karawoo marked this pull request as ready for review May 9, 2025 23:49
Copy link
Collaborator

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this!

Copy link
Collaborator

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Neal Richardson <[email protected]>
@karawoo karawoo merged commit 3e959ec into main May 13, 2025
19 checks passed
@karawoo karawoo deleted the respect-include branch May 13, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_content() discards tags when guid parameter is provided
2 participants