Skip to content

5.15.8 #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 0 commits into from
Dec 17, 2021
Merged

5.15.8 #101

merged 0 commits into from
Dec 17, 2021

Conversation

jackpot51
Copy link
Member

@jackpot51 jackpot51 requested review from a team December 14, 2021 18:08
@jackpot51 jackpot51 self-assigned this Dec 14, 2021
@jackpot51 jackpot51 mentioned this pull request Dec 14, 2021
@13r0ck
Copy link

13r0ck commented Dec 16, 2021

Galp5 is still having suspend issues while in NVIDIA mode

@jackpot51
Copy link
Member Author

Galp5 is still having suspend issues while in NVIDIA mode

Are these regressions from 5.15.5?

@13r0ck
Copy link

13r0ck commented Dec 16, 2021

Are these regressions from 5.15.5?

No not a regression from 5.15.5, Levi asked that I document that it is still broken here anyway.

Copy link

@13r0ck 13r0ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Updating to new kernel works with apt update && apt upgrade
    • No new dependencies are required for kernel update
  • system76-power still opperates as expected (across Intel/NVIDIA/switchable machines)
  • Mic in
  • Audio out:
    • Laptop's built-in speakers
    • Headphones
    • Display Port
    • HDMI
  • Video out via:
    • DisplayPort
    • HDMI
  • Thunderbolt docking station:
    • HDMI and DisplayPort
    • External storage device
    • Networking
  • Suspend and resume: (Still broken on Galp5 in NVIDIA mode)
    • Switchable graphics laptops
      • In Hybrid graphics mode
      • In Nvidia graphics mode
      • In Integrated graphics mode
    • Nvidia desktop
    • Discrete AMD desktop
    • Integrated Intel desktop
    • Integrated AMD desktop
    • 150 suspend/resume cycles (fwts s3 --s3-multiple 150)
  • Kernel works in:
    • Ubuntu LTS
    • Pop!_OS LTS
    • Latest Pop!_OS
  • Graphics drivers included in the kernel (Intel/AMD)
    • Switchable/hybrid graphics and graphics switching
  • Steam
    • Steam installs via the Pop!_OS .deb in Pop!_Shop
    • Steam launches from launcher
    • Linux native game installs and runs
    • Proton game installs and runs
  • Virtualbox installs and works as expected

@jackpot51 jackpot51 merged commit 0ede46a into master Dec 17, 2021
@jackpot51 jackpot51 deleted the 5.15.8 branch December 20, 2021 18:27
jackpot51 pushed a commit that referenced this pull request Apr 26, 2022
commit 6d82ad1 upstream.

Running generic/406 causes the following WARNING in btrfs_destroy_inode()
which tells there are outstanding extents left.

In btrfs_get_blocks_direct_write(), we reserve a temporary outstanding
extents with btrfs_delalloc_reserve_metadata() (or indirectly from
btrfs_delalloc_reserve_space(()). We then release the outstanding extents
with btrfs_delalloc_release_extents(). However, the "len" can be modified
in the COW case, which releases fewer outstanding extents than expected.

Fix it by calling btrfs_delalloc_release_extents() for the original length.

To reproduce the warning, the filesystem should be 1 GiB.  It's
triggering a short-write, due to not being able to allocate a large
extent and instead allocating a smaller one.

  WARNING: CPU: 0 PID: 757 at fs/btrfs/inode.c:8848 btrfs_destroy_inode+0x1e6/0x210 [btrfs]
  Modules linked in: btrfs blake2b_generic xor lzo_compress
  lzo_decompress raid6_pq zstd zstd_decompress zstd_compress xxhash zram
  zsmalloc
  CPU: 0 PID: 757 Comm: umount Not tainted 5.17.0-rc8+ #101
  Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS d55cb5a 04/01/2014
  RIP: 0010:btrfs_destroy_inode+0x1e6/0x210 [btrfs]
  RSP: 0018:ffffc9000327bda8 EFLAGS: 00010206
  RAX: 0000000000000000 RBX: ffff888100548b78 RCX: 0000000000000000
  RDX: 0000000000026900 RSI: 0000000000000000 RDI: ffff888100548b78
  RBP: ffff888100548940 R08: 0000000000000000 R09: ffff88810b48aba8
  R10: 0000000000000001 R11: ffff8881004eb240 R12: ffff88810b48a800
  R13: ffff88810b48ec08 R14: ffff88810b48ed00 R15: ffff888100490c68
  FS:  00007f8549ea0b80(0000) GS:ffff888237c00000(0000) knlGS:0000000000000000
  CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
  CR2: 00007f854a09e733 CR3: 000000010a2e9003 CR4: 0000000000370eb0
  DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
  DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
  Call Trace:
   <TASK>
   destroy_inode+0x33/0x70
   dispose_list+0x43/0x60
   evict_inodes+0x161/0x1b0
   generic_shutdown_super+0x2d/0x110
   kill_anon_super+0xf/0x20
   btrfs_kill_super+0xd/0x20 [btrfs]
   deactivate_locked_super+0x27/0x90
   cleanup_mnt+0x12c/0x180
   task_work_run+0x54/0x80
   exit_to_user_mode_prepare+0x152/0x160
   syscall_exit_to_user_mode+0x12/0x30
   do_syscall_64+0x42/0x80
   entry_SYSCALL_64_after_hwframe+0x44/0xae
   RIP: 0033:0x7f854a000fb7

Fixes: f0bfa76 ("btrfs: fix ENOSPC failure when attempting direct IO write into NOCOW range")
CC: [email protected] # 5.17
Reviewed-by: Johannes Thumshirn <[email protected]>
Tested-by: Johannes Thumshirn <[email protected]>
Reviewed-by: Filipe Manana <[email protected]>
Signed-off-by: Naohiro Aota <[email protected]>
Signed-off-by: David Sterba <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gnome Shell is repeatedly crashing in 21.10 and ignores display and power settings on restart (turns off the screen after 30s)
3 participants