cleanup: Remove Size::Hardcoded from applet size variants#886
Open
ryanabx wants to merge 1 commit intopop-os:masterfrom
Open
cleanup: Remove Size::Hardcoded from applet size variants#886ryanabx wants to merge 1 commit intopop-os:masterfrom
ryanabx wants to merge 1 commit intopop-os:masterfrom
Conversation
The most adequate replacement for applets that want to be custom-sized is to use PanelSize::Custom(n). This does lose the granularity between width and height though Signed-off-by: Ryan Brue <ryanbrue.dev@gmail.com>
|
Could you give an example of how we could use PanelSize::Custom(n) this i was currently trying to set the size of my applet while i was able to get the height where i wanted by setting the size of the elements inside the width would not change beyond a certain size no matter what i tried |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most adequate replacement for applets that want to be custom-sized is to use
PanelSize::Custom(n). This does lose the granularity between width and height though.Might need discussion on whether people use width and height in community-made applets?