sctk: Improvements for handling outputs#14
Merged
wash2 merged 2 commits intopop-os:masterfrom Dec 23, 2022
Merged
Conversation
With these lines, a subscription seems to receive output events twice. Without it, only once as expected.
This is the most flexible solution, and using output events, it is possible to create surfaces for specific outputs or all. Matching by make/model is a bad idea anyway. Matching by name may be appropriate.
wash2
approved these changes
Dec 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this I'm able to spawn a fullscreen layer shell surface for each output.
For some reason my application doesn't seem to get output events until I move the mouse (with an initial layer surface that's 1x1 pixel). And if I destroy the initial surface in
Application::new, it never does.There should also be a way to run with no initial surface, but I guess it currently relies on an initial surface to initialize an EGL display/context.