From Clap to Clap_lex #1260
Open
From Clap to Clap_lex #1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmstick
requested changes
Jun 30, 2025
mmstick
reviewed
Jun 30, 2025
| "WindowManagement" => Some(Self::WindowManagement), | ||
| "Wired" => Some(Self::Wired), | ||
| "Wireless" => Some(Self::Wireless), | ||
| "Workspaces" => Some(Self::Workspaces), |
There was a problem hiding this comment.
This is not in the same format as clap was using before. Make sure every desktop entry works.
There was a problem hiding this comment.
@mmstick By that you mean only conditionnal compilation annotation? If not I tested it... this if the Clap_lex way to do it. :p
There was a problem hiding this comment.
No, our desktop entries are launched via the name of the page, but it is not written in the same way as in the source code. WindowManagement is Exec=cosmic-settings window-management, for example. So again, make sure the desktop entries work with the change.
Format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mmstick mentioned to me that he would like to see clap_lex instead of clap, so... here it is.
To my knowledge, it works perfectly.
The only bad news is that I removed the cfg attributes from individual functions, as they made the code really hard to read.
I think there are better ways to handle specific functionality when it's not applicable to a platform than doing it at compile time.
Feel free to hate it, but please don't leave me in the dark.