-
Notifications
You must be signed in to change notification settings - Fork 151
Change wifi icon to one single icon #1245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
instead of a seperate lock icon
This doesn't technically match designs, but IMO, it looks quite a bit better. |
That's fair. I just want to note that these icons seems to have been added only 10 months ago, which is probably after the design document. |
Where are the new icons coming from?
Those concerns are the main reason the icons have not been changed to what is suggested here earlier. |
We should drop the icon patch for now, and move it to its own PR then. |
fd5584e
to
68bdd3d
Compare
I created a new one for the open wifi instead #1248, since the icon discussion is here. |
This also happens with the network applet, since the WiFi icon ends up looking misaligned compared to other applet icons. So the icons should possibly be tweaked to be centered with and without the lock icon. |
Change the icons to one instead of using two icons.