Skip to content

Conversation

Lampan-git
Copy link
Contributor

@Lampan-git Lampan-git commented Jun 24, 2025

Change the icons to one instead of using two icons.

Before After
Screenshot_2025-06-25_18-03-51 Screenshot_2025-06-24_18-48-33

instead of a seperate lock icon
@git-f0x
Copy link
Contributor

git-f0x commented Jun 25, 2025

This doesn't technically match designs, but IMO, it looks quite a bit better.
Though there are maybe potential accessibility concerns, so needs UX approval regardless.

@Lampan-git
Copy link
Contributor Author

That's fair. I just want to note that these icons seems to have been added only 10 months ago, which is probably after the design document.

@mmstick mmstick requested a review from a team June 25, 2025 12:16
@maria-komarova
Copy link

maria-komarova commented Jun 25, 2025

Where are the new icons coming from?
There were a couple small concerns with them using the lock like that:

  • I worry the lock is too small to be easily recognizable, at least for some people. Although familiarity of that kind of placement should help a little. But the concern remains, the lock image gets too small.
  • Wi-fi icon without a lock looks misaligned compared to other icons if used next to them. This happens because of the free space allocated for the lock image. So we'd need to make sure the icon is not used anywhere in that context or do something about the icon.

Those concerns are the main reason the icons have not been changed to what is suggested here earlier.

@mmstick
Copy link
Member

mmstick commented Jun 25, 2025

We should drop the icon patch for now, and move it to its own PR then.

@Lampan-git Lampan-git force-pushed the change_wifi_secure_icon branch from fd5584e to 68bdd3d Compare June 25, 2025 16:11
@Lampan-git
Copy link
Contributor Author

Lampan-git commented Jun 25, 2025

Where are the new icons coming from?

https://github.com/pop-os/cosmic-icons/blob/master/extra/scalable/status/network-wireless-secure-signal-ok-symbolic.svg

We should drop the icon patch for now, and move it to its own PR then.

I created a new one for the open wifi instead #1248, since the icon discussion is here.

@Lampan-git Lampan-git changed the title Enable connection to open Wifi, and change wifi icon. Change wifi icon to one single icon Jun 25, 2025
@git-f0x
Copy link
Contributor

git-f0x commented Jul 3, 2025

Wi-fi icon without a lock looks misaligned compared to other icons if used next to them. This happens because of the free space allocated for the lock image. So we'd need to make sure the icon is not used anywhere in that context or do something about the icon.

This also happens with the network applet, since the WiFi icon ends up looking misaligned compared to other applet icons. So the icons should possibly be tweaked to be centered with and without the lock icon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants