merge last changes + .md notes generation #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luk-z
commented
Feb 23, 2021
Luk-z
commented
- updates with last reactjs/server-components-demo commits
- add generation of .md notes to avoid delete note errors
This PR addresses a couple of minor grammatical errors. Nothing major. Enjoying the demo, thank you! 🙌
Specify nodejs version needed
Add Docker setup
👌 IMPROVE: Minor Grammatical Edits
Downgrade package-lock.json to lockfileVersion 1 to support Node 14.9
* fix: added cross-env * Downgrade package-lock.json to lockfileVersion 1 to support Node 14.9 * fix: added cross-env * chore: added npm lock file * chore: pull remote changes Co-authored-by: Kanitkorn S <[email protected]> Co-authored-by: Dan Abramov <[email protected]>
…actjs#18) * add cross-env to set NODE_ENV on windows and fix build on windows * Update package-lock.json * Update api.server.js * Update package.json Co-authored-by: Ahsan Sohail (213979) <AhSohail@KHI-ICX-AHSANS> Co-authored-by: Dan Abramov <[email protected]>
* Fixes docker-compose & pg initialization - ./scripts/init_db.sh is not executable (/bin/bash: bad interpreter: Permission denied) - same script fails because user is already created, only table creation is necessary. * Actually fix docker-compose development workflow * Incorporate PR feedback * Remove credentials.json
* add demo walkthrough for easy consumption * Update README.md * Update README.md * Update README.md
With this change, as well as a change to react-fs, this repo will be able to support Node.js 12 (tested locally). I can't seem to find the repo for react-fs though to propose the change ¯\_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.