Treat empty scope in token response as None instead of failing #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwojnowski
reviewed
May 21, 2024
| @@ -26,6 +27,12 @@ trait CirceJsonDecoders { | |||
| implicit def jsonDecoder[A](implicit decoder: Decoder[A]): JsonDecoder[A] = | |||
| (data: String) => io.circe.parser.decode[A](data).leftMap(error => JsonDecoder.Error(error.getMessage, cause = Some(error))) | |||
|
|
|||
| implicit val optionScopeDecoder: Decoder[Option[Scope]] = | |||
There was a problem hiding this comment.
This is out of scope of this PR, as it would be a breaking change, but this should be a Set[Scope], rather than Option[Scope]. According to the RFC:
The value of the scope parameter is expressed as a list of space-
delimited, case-sensitive strings.
(...)
If the value contains multiple space-delimited
strings, their order does not matter, and each string adds an
additional access range to the requested scope.
| @@ -60,7 +60,7 @@ trait ClientCredentialsAccessTokenResponseDeserializationSpec extends AnyFlatSpe | |||
| ) | |||
| } | |||
|
|
|||
| "Token with empty scope" should "not be deserialized" in { | |||
| "Token with empty scope" should "be deserialized with None scope" in { | |||
There was a problem hiding this comment.
I think this also served as a test for an invalid scope. How about adding another case with invalid scope, e.g. "déjà vu"?
majk-p
force-pushed
the
empty-string-scope-as-none
branch
from
44d46f3 to
1a79774
Compare
jwojnowski
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #486
We might need to wait for #487 with merging, as we did some build fixes there