fix(python): Fix interchange protocol data buffer dtype #10787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there is an issue with the way data buffer dtypes are represented across various implementations of the protocol (ours, pyarrow, pandas, ...).
The issue is that the data buffer is assigned the column dtype. This is only correct for integers and floats. Categoricals, strings, and datetime types have a some integer as their physical representation. The data buffer should have this physical data type associated with it.
The fix in this PR is simple enough, but this cannot be merged until other libraries fix their
from_dataframe
implementation. I opened some issues:from_dataframe
incorrect pandas-dev/pandas#54781from_dataframe
incorrect apache/arrow#37598When those libraries update their
from_dataframe
implementations per the issues above, the roundtrip tests should pass and this can be merged.