Let all events from files and chunks bubble up and make them accessible for users #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fire them there too)
anne-gropler
reviewed
Feb 2, 2024
UniquePanda
force-pushed
the
13-re-add-some-events-that-were-removed-before
branch
from
a91c06b to
0819f9d
Compare
UniquePanda
force-pushed
the
13-re-add-some-events-that-were-removed-before
branch
from
0819f9d to
c9ec604
Compare
anne-gropler
approved these changes
Feb 2, 2024
anne-gropler
deleted the
13-re-add-some-events-that-were-removed-before
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds re-firing of all events that are fired by
ResumableChunks orResumableFiles so that they can be listened to via the main resumable object.I also updated the readme part that talks about events to include all of the new events. I also did some re-ordering and rephrasing there.
Other updates to the readme will be done with #9.
This PR didn't change or remove any events that were accessible previously, so there are no breaking changes.