feat: preview files #1945
Merged
feat: preview files #1945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- download and preview file for a campaign application - create a UploadedFilesList component that takes the fetch and delete query and labels and shows a list of uploaded files with download/preview/delete actions
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
slavcho
approved these changes
Sep 30, 2024
Contributor
slavcho
left a comment
slavcho
left a comment
There was a problem hiding this comment.
I love the preview feature.
We can integrate the same in the campaign reports later.
| return ( | ||
| <UploadedFilesList | ||
| files={files} | ||
| downloadQuery={(f) => fetchCampaignApplicationFile(f.id, session).then((r) => r.data)} |
Contributor
There was a problem hiding this comment.
maybe we should use await, insead of .then()
Contributor
Author
There was a problem hiding this comment.
Help me understand what makes the async way preferable here? Can we agree it does the same thing in the end or did I miss something?
Contributor
There was a problem hiding this comment.
Sure - I will merge it although I don't agree with it.
Following the project style and guidelines makes the code easier to read and understand.
CamelCase and snake_case are both good naming conventions, yet merging them is not a good idea.
| return blobUrls[file.id] | ||
| } else { | ||
| return downloadQuery(file) | ||
| .then((blob) => { |
ani-kalpachka
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file-preview-small.mp4