Skip to content

fix: Correct status code and message returned on invalid file upload #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sashko9807 merged 3 commits into from
Sep 15, 2025
Merged

fix: Correct status code and message returned on invalid file upload #700

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f01a714
fix: Correct status code and message returned on invalid file upload
Ivan-Shaml Sep 7, 2025
2c74cae
Revert "fix: Correct status code and message returned on invalid file…
Ivan-Shaml Sep 13, 2025
6311a29
Address comments
Ivan-Shaml Sep 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions apps/api/src/common/files.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import path from 'path'
import { UnsupportedMediaTypeException } from '@nestjs/common'

interface File {
fieldname: string
Expand Down Expand Up @@ -34,7 +35,7 @@ export function validateFileType(
'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet',
]
if (!mimeAllowlist.includes(file.mimetype)) {
return cb(new Error('File mime type is not allowed'), false)
return cb(new UnsupportedMediaTypeException('File mime type is not allowed'), false)
}

const allowedExtensions = /txt|json|pdf|jpeg|jpg|png|xml|xlsx|xls|docx/
Expand All @@ -47,7 +48,10 @@ export function validateFileType(
}
const isExtensionSupported = allowedExtensions.test(ext)
if (!isExtensionSupported) {
return cb(new Error('File extension is not allowed: ' + file.filename), false)
return cb(
new UnsupportedMediaTypeException('File extension is not allowed: ' + file.filename),
false,
)
}

cb(null, true)
Expand Down
Loading