Merged
Conversation
|
Would also close #185 |
Contributor
Author
|
Thanks @oBusk, linked that issue too. |
Contributor
Author
|
If you would like to test this in your workflows, you can use the hash of the latest commit from this branch as a version: - name: Setup pnpm
# https://github.com/pnpm/action-setup/pull/188
uses: pnpm/action-setup@0bc9da32cd356746083d9e2b8848bad8b974c72c
with:
cache: true |
* no semicolons * no star imports * import order
KSXGitHub
approved these changes
Dec 6, 2025
zkochan
reviewed
Dec 7, 2025
|
|
||
| **Optional** (_type:_ `boolean`, _default:_ `false`) Whether to cache the pnpm store directory. | ||
|
|
||
| ### `cache_dependency_path` |
Member
There was a problem hiding this comment.
I feel like this setting name is confusing.
Contributor
Author
There was a problem hiding this comment.
This is what it's called in actions/setup-node. I don't love it either, but couldn't come up with anything better. I'm happy to rename it if anyone has a better suggestion.
zkochan
approved these changes
Dec 7, 2025
Contributor
Author
|
Thanks for reviewing this! Looking forward to seeing this released soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm can install Node runtime as a dependency, but
actions/setup-nodeis still needed to cache the pnpm store (as currently suggested in the readme). Alternative is to add something like this to your workflow:With this PR, the same can be accomplished simply by setting
cache: truein setup pnpm action:The implementation is based on actions/setup-node.
Closes #70, closes #80, closes #82, closes #152, closes #173.
Once stable, this could be enabled by default, although I think it would require a major version bump.