obj: always log an error that occurs in heap action processing #5589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomasz Gromadzki <[email protected]>
wlemkows
reviewed
Apr 21, 2023
| @@ -269,13 +269,13 @@ palloc_heap_action_exec(struct palloc_heap *heap, | |||
| /* suppress unused-parameter errors */ | |||
| SUPPRESS_UNUSED(heap); | |||
|
|
|||
| #ifdef DEBUG | |||
There was a problem hiding this comment.
You add not only logging but also reading. The thought is that this can affect performance.
There was a problem hiding this comment.
This will cause one extra PMem memory access on all heap operations. It might be worth checking if the performance impact isn't negligible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
obj: always log an error that occurs in heap action processing
Signed-off-by: Tomasz Gromadzki [email protected]
This change is