-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add Slider/RangeSlider tooltip.format and tooltip.style. #2723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0ca1b94
Add Slider/RangeSlider tooltip.format and tooltip.style.
T4rk1n 45e8aa8
Update changelog.
T4rk1n 073775c
Update changelog.
T4rk1n f4ea5e4
Update components/dash-core-components/src/components/RangeSlider.rea…
T4rk1n cd9c523
Rename format -> template.
T4rk1n 638abf1
Merge branch 'dev' into slider-tips
T4rk1n 06fb03a
docstring typos
alexcjohnson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
components/dash-core-components/src/components/css/sliders.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
/* Fix the default tooltip style height conflicting with the actual size of the tooltip. */ | ||
.rc-slider-tooltip-content > .rc-slider-tooltip-inner { | ||
height: unset; | ||
min-height: 20px; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
components/dash-core-components/src/utils/formatSliderTooltip.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
import {replace, path, split, concat, pipe} from 'ramda'; | ||
|
||
export const formatSliderTooltip = (template, value) => { | ||
return replace('{value}', value, template); | ||
}; | ||
|
||
export const transformSliderTooltip = (funcName, value) => { | ||
const func = pipe( | ||
split('.'), | ||
s => concat(['dccFunctions'], s), | ||
s => path(s, window) | ||
)(funcName); | ||
if (!func) { | ||
throw new Error( | ||
`Invalid func for slider tooltip transform: ${funcName}` | ||
); | ||
} | ||
return func(value); | ||
}; |
4 changes: 4 additions & 0 deletions
4
components/dash-core-components/tests/integration/sliders/assets/transform.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
window.dccFunctions = window.dccFunctions || {}; | ||
window.dccFunctions.transformTooltip = function(value) { | ||
return "Transformed " + value | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.