Remove future, __future__ and py2/py3
#1726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anders-kiaer
force-pushed
the
future_remove
branch
from
7e2279a to
9c27f0a
Compare
anders-kiaer
force-pushed
the
future_remove
branch
from
9c27f0a to
825bf8a
Compare
| @@ -109,7 +103,7 @@ def strip_relative_path(requests_pathname, path): | |||
|
|
|||
| # pylint: disable=no-member | |||
| def patch_collections_abc(member): | |||
| return getattr(collections if utils.PY2 else collections.abc, member) | |||
| return getattr(collections.abc, member) | |||
There was a problem hiding this comment.
In fact we should be able to 🔪 patch_collections_abc entirely
| @@ -1,5 +1,3 @@ | |||
| from __future__ import print_function | |||
There was a problem hiding this comment.
Ah, there will be a little merge conflict with #1734 where we remove all these build artifacts... (dash/dash_table, dash/dcc, dash/html)
alexcjohnson
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Python 2 support is dropped in
dev🎉 here is a community PR on the transition of the code base.grep -rnw . -e 'substring'now returns an empty list for all substringspy2,py3,from future,import future,__future__,_strings.Contributor Checklist