Standard import "import io" should be placed before "from setuptools… #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…import setup, find_packages" (wrong-import-order). Also fix continued line indentation. These issues are found from using Pylint https://www.pylint.org/
|
You can see an example of the standard import order here https://stackoverflow.com/questions/22722976/import-order-coding-standard |
|
Nice, thanks! I had thought that flake8 would catch all of these things but apparently not. It would be good to get pylint in the acceptance tests as well. Here's where we do the flake8 tests: Line 15 in 45a165b |
HammadTheOne
pushed a commit
to HammadTheOne/dash
that referenced
this pull request
May 22, 2021
HammadTheOne
pushed a commit
to HammadTheOne/dash
that referenced
this pull request
May 28, 2021
HammadTheOne
pushed a commit
that referenced
this pull request
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… import setup, find_packages" (wrong-import-order). Also fix continued line indentation. These issues are found from using Pylint https://www.pylint.org/