Skip to content

Updating CI Python images #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 18, 2020
Merged

Updating CI Python images #1507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a836010
goog:loggingPrefs
Dec 17, 2020
40f1b9a
bump CI images
Dec 17, 2020
3f3abbd
trigger build
Dec 17, 2020
c69b2eb
browser behavior change rdif001
Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

artifacts:
docker:
- image: circleci/python:3.7.6-stretch-node-browsers
- image: circleci/python:3.7.9-stretch-node-browsers
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump to latest patch version for each Python version, side-effect is that this updates the version of Chrome

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two thoughts:

  1. should we switch to circleci's "next-gen" images? https://circleci.com/developer/images/image/cimg/python
  2. Maybe a bigger task, but should we be switching from py3.7 to py3.9?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexcjohnson I can certainly look into those. If possible I'd like to do these in a follow up as this work was initiated by an issue @harryturr encountered as part of his current work assignment.

auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -33,7 +33,7 @@ jobs:
lint-unit-37: &lint-unit
working_directory: ~/dash
docker:
- image: circleci/python:3.7.6-stretch-node-browsers
- image: circleci/python:3.7.9-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
lint-unit-36:
<<: *lint-unit
docker:
- image: circleci/python:3.6.9-stretch-node-browsers
- image: circleci/python:3.6.12-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -95,7 +95,7 @@ jobs:
build-core-37: &build-core
working_directory: ~/dash
docker:
- image: circleci/python:3.7.6-stretch-node-browsers
- image: circleci/python:3.7.9-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
build-core-36:
<<: *build-core
docker:
- image: circleci/python:3.6.9-stretch-node-browsers
- image: circleci/python:3.6.12-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -153,7 +153,7 @@ jobs:
build-misc-37: &build-misc
working_directory: ~/dash
docker:
- image: circleci/python:3.7.6-stretch-node-browsers
- image: circleci/python:3.7.9-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down Expand Up @@ -192,7 +192,7 @@ jobs:
build-misc-36:
<<: *build-misc
docker:
- image: circleci/python:3.6.9-stretch-node-browsers
- image: circleci/python:3.6.12-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down Expand Up @@ -341,7 +341,7 @@ jobs:
test-37: &test
working_directory: ~/dash
docker:
- image: circleci/python:3.7.6-stretch-node-browsers
- image: circleci/python:3.7.9-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down Expand Up @@ -386,7 +386,7 @@ jobs:
test-36:
<<: *test
docker:
- image: circleci/python:3.6.9-stretch-node-browsers
- image: circleci/python:3.6.12-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down
1 change: 1 addition & 0 deletions dash/testing/browser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,7 @@ def _get_chrome(self):

capabilities = DesiredCapabilities.CHROME
capabilities["loggingPrefs"] = {"browser": "SEVERE"}
capabilities["goog:loggingPrefs"] = {"browser": "SEVERE"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add ChromeDriver 75+ correct capabilities. Keep the old one for compatibility.


if "DASH_TEST_CHROMEPATH" in os.environ:
options.binary_location = os.environ["DASH_TEST_CHROMEPATH"]
Expand Down
2 changes: 1 addition & 1 deletion tests/integration/renderer/test_iframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,4 +57,4 @@ def apply_cors(response):
dash_duo.wait_for_element_by_id("btn").click()
dash_duo.wait_for_element("#output-0").text == "0=1"

assert len(dash_duo.get_logs()) != 0
assert dash_duo.get_logs() == []
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This log entry in Chrome 87 is a warning and now not included.