-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Loosen testing requirements & improve testing #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e0a9446
c3a7403
399373a
15ad7f5
ec35ca6
f51749a
37b01bc
32dee50
2643e50
8914bb3
c24b382
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,15 @@ | ||
dash_flow_example==0.0.5 | ||
dash-dangerously-set-inner-html | ||
isort==4.3.21 | ||
mock==4.0.1;python_version>="3.0" | ||
isort==4.3.21;python_version<"3.7" | ||
mock==4.0.3;python_version>="3.0" | ||
mock==3.0.5;python_version=="2.7" | ||
flake8==3.7.9 | ||
PyYAML==5.3 | ||
pylint==1.9.4;python_version<"3.7" | ||
pylint==2.3.1;python_version=="3.7" | ||
astroid==2.2.5;python_version=="3.7" | ||
flake8==3.8.4 | ||
PyYAML==5.3.1 | ||
pylint==1.9.5;python_version<"3.7" | ||
pylint==2.6.0;python_version>="3.7" | ||
astroid==2.4.2;python_version>="3.7" | ||
black==19.10b0;python_version>="3.0" | ||
virtualenv==20.0.10;python_version=="2.7" | ||
fire==0.2.1 | ||
coloredlogs==14.0 | ||
virtualenv==20.2.2;python_version=="2.7" | ||
fire==0.3.1 | ||
coloredlogs==15.0 | ||
flask-talisman==0.7.0 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Moved |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,12 @@ | ||
pytest==6.0.1;python_version>="3.0" | ||
pytest==4.6.9;python_version=="2.7" | ||
pytest-sugar==0.9.4 | ||
pytest-mock==3.2.0;python_version>="3.0" | ||
pytest-mock==2.0.0;python_version=="2.7" | ||
lxml==4.6.1 | ||
selenium==3.141.0 | ||
percy==2.0.2 | ||
cryptography==3.0 | ||
requests[security]==2.21.0 | ||
beautifulsoup4==4.8.2 | ||
waitress==1.4.3 | ||
flask-talisman==0.7.0 | ||
pytest>=6.0.2;python_version>="3.0" | ||
pytest>=4.6,<5;python_version=="2.7" | ||
pytest-sugar>=0.9.4 | ||
pytest-mock>=3.2.0;python_version>="3.0" | ||
pytest-mock>=2.0.0,<3;python_version=="2.7" | ||
lxml>=4.6.2 | ||
selenium>=3.141.0 | ||
percy>=2.0.2 | ||
requests[security]>=2.21.0 | ||
beautifulsoup4>=4.8.2,<=4.9.3;python_version=="2.7" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
beautifulsoup4>=4.8.2;python_version>="3.0" | ||
waitress>=1.4.4 |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we sanity test these flake8/pylint changes against the other core repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have an annoying habit of changing their rules..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call - they may well need their own updates to
.pylintrc
files, or syntax updates. PRs coming.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plotly/dash-core-components#907, plotly/dash-html-components#171, plotly/dash-table#857 - All three, I started with this branch, got tests passing, then reverted to the dev branch of dash and tests still pass - All that was required (other than prohibiting the latest
xlrd
) was a couple of linting exclusions.